Add new gcp host attributes and update gcp semconv #4263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
gce_hostname
branch
2 times, most recently
from
82e90df
to
7ac6623
Compare
5 tasks
dashpole
changed the title
dashpole
force-pushed
the
gce_hostname
branch
2 times, most recently
from
b6c923d
to
14797ae
Compare
dashpole
force-pushed
the
gce_hostname
branch
from
14797ae
to
6f1b636
Compare
Codecov Report
@@ Coverage Diff @@
## main #4263 +/- ##
=====================================
Coverage 79.4% 79.4%
=====================================
Files 166 166
Lines 10374 10376 +2
=====================================
+ Hits 8244 8246 +2
Misses 1996 1996
Partials 134 134
|
dmathieu
approved these changes
Sep 6, 2023
MrAlias
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4261 (comment)
Add new resource attributes from open-telemetry/semantic-conventions#15 to the gcp resource detector.
Blocked by #4198